test: add integration tests #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
…or-poc into feat/add-examples
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
0xRaccoon
changed the title
Signed-off-by: 0xRaccoon <[email protected]>
…rland/wonderland-governooor-poc into test/add-wonder-votes-unit-tests
Signed-off-by: 0xRaccoon <[email protected]>
…onderland/wonderland-governooor-poc into test/add-integration-tests Signed-off-by: 0xRaccoon <[email protected]>
0xParticle
reviewed
Dec 27, 2023
solidity/test/unit/WonderVotes.t.sol
Outdated
| vm.stopPrank(); | ||
| } | ||
|
|
||
| function test_Revert_ZeroWeight(uint8 _proposalType) public { |
There was a problem hiding this comment.
should the contract revert or ignore in this case?
There was a problem hiding this comment.
good question, I think that a Delegatee with 0 weight is an invalid case and should revert just to avoid user mistakes 🤔
0xParticle
previously approved these changes
Dec 27, 2023
…or-poc into test/add-integration-tests Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
0xParticle
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear 🤖
Closes WG-5